Add log flume lifthill sound #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got it on a nice volume level and looping correctly. I like the overall feel it gives to the log flume and makes it more of a present ride. This was supposed to go to OpenRCT2#20258, but I might decide to make a seperate PR for it.
tupaschoal
reviewed
Feb 15, 2024
|
i had it ready a few months ago already, but never published it. It wasn't looping correctly and it was a tad loud. That makes me think i should probably go over all sfx again sometime to adjust them, especially the toilet sound apparently that's way too loud for people 😂 |
tupaschoal
approved these changes
Feb 15, 2024
|
The only issue will be that it will only be audible on currently cheated in lifthills. Ofcourse the other PR will take care of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got it on a nice volume level and looping correctly. I like the overall feel it gives to the log flume and makes it more of a present ride. This was supposed to go to OpenRCT2#20258, but I might decide to make a seperate PR for it.
Requires the updating of
audio.hon the OpenRCT2 main repo.In my test PR I called this LiftFlume (Row 133): https://github.com/karst/OpenRCT2/tree/log-flume-sound